dstandish commented on a change in pull request #15013: URL: https://github.com/apache/airflow/pull/15013#discussion_r613745380
########## File path: airflow/providers/hashicorp/secrets/vault.py ########## @@ -18,8 +18,10 @@ """Objects relating to sourcing connections & variables from Hashicorp Vault""" from typing import Optional +from airflow.models.connection import Connection from airflow.providers.hashicorp._internal_client.vault_client import _VaultClient # noqa from airflow.secrets import BaseSecretsBackend +from airflow.secrets.local_filesystem import _create_connection Review comment: So you are saying that if this vault provider expects a `from_dict` method on `Connection` (added in 2.1) the provider won't work with 2.0, but we've promised that it will. should we perhaps then just merge this as is? or perhaps duplicate this private function into this provider into a vault provider utils module with a deprecation warning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org