drboyer opened a new pull request #15949: URL: https://github.com/apache/airflow/pull/15949
This PR closes #15948 by adding support for `snowflake` connection types to the list in `get_hook` in the Connection class. Two comments for reviewers: 1. I wasn't sure if it was appropriate to add tests for this somewhere. It seems that either in `test_core.py` or `test_sql_sensor.py` would be appropriate, but none of the existing tests in either of those files seemed relevant to this sort of change (they don't exhaustively test the different hook types). Happy to add something if pointed in the right direction, though. 2. I wasn't exactly sure what the right base branch was for a change that only seems to affect 1.10.x branches. I haven't used or looked at Airflow 2.x code in detail to know if the same issue exists there, but the code does seem refactored to remove this big if-else block in the master branch. Please let me know if this should have a different base branch. Thanks for your review! --- Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
