potiuk commented on issue #15933:
URL: https://github.com/apache/airflow/issues/15933#issuecomment-846433474


   Yeah. I see the case @eladkal. But I kind of see how Plyvel is very 
different from all other Google "core" components. Which 
cloud/ads/marketing_platform might be really "core" google business, where 
Plyvel is more of a "side" thing and could be fully separated out. I think it 
is much easier to separate out plyvel as a provider than splitting google 
"core" one. 
   
   I am quite torn on this one. I see the benefits of keeping all those as 
single "provider" - on the other hand the benefits of splitting it are 
"potentially good" but it makes them also difficult to work together when 
installed with all the dependencies - it will be easy for example to run in a 
situation where "cloud" dependencies are different (and conflicting) with "ads" 
dependencies. I think until we figure out (possibly) some way of separating the 
dependencies out between tasks, this might be a difficult one to tackle and 
rather than "origin" (google), the "independence" of a package might be more 
important.
   
   I think the "extras" approach where plyvel is "optional" google extra 
dependency is maybe not perfect, but it kind of join both worlds. On one hand 
we have them together by "ownership", on the other hand we have just a problem 
of "environment" set properly for plyvel to work (so plyvel db libs installed). 
I think the current approach is kinda sustainable and does not introduce too 
much of complexity.
   
   As usually with "compromise" solutions, it's not perfect but maybe it's 
"good enough"?  As long as it works, it could be "OK". I am also quite OK to 
separate just plyvel as @anitakar suggested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to