huozhanfeng edited a comment on pull request #16768: URL: https://github.com/apache/airflow/pull/16768#issuecomment-873738826
> Logic LGRM! A couple of minor comments/questions. > > I wonder if/how we can refactor `SimpleTaskInstance` to prevent this kind of error in the future. Right now, if a field is added to `TaskInstace`, `SimpleTaskInstace` and `_execute_task_callbacks` needed to be checked to pass them on. This can be difficult to maintain. Agree with you, maybe we can raise an independent pr to improve related logic in the future... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
