potiuk edited a comment on pull request #16885: URL: https://github.com/apache/airflow/pull/16885#issuecomment-876449588
Should we just remove the mapping altogether? I just tested it and it still works. The mapping with just the container port still creates a mapping to host (but with ephemeral port number). Removing the mapping makes `redis` only available for the internal docker-compose network, not in the host. As discussed - it's a development docker-compose, but people might use it as example, so likely it's good to remove it. Unlike webserver/flower that it's good to map to host, I do not imagine that someone might want to have direct access from host to redis (they can still modify the dockerfile if they want) - in a normal "user" case. But for some cases it can be useful. Maybe then we should simply comment out the mapping and (add comment specifying why it is commented out and that you might want to uncomment it, if you want to access redis directly ? I think that will be both - development friendly and safe for copy&paste cases. Also maybe we could - in the same way - create and comment out 5432 port for Postgres container? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
