eladkal commented on a change in pull request #16926:
URL: https://github.com/apache/airflow/pull/16926#discussion_r667463452
##########
File path: docs/apache-airflow/best-practices.rst
##########
@@ -109,6 +109,9 @@ or if you need to deserialize a json object from the
variable :
{{ var.json.<variable_name> }}
+Alternative option is to read from the environment variables in the top level
python code instead of airflow variables.
+This will avoid new connections to airflow metadata DB everytime Airflow
parses the python file.
+
Review comment:
I think it's better to place this text in the following paragraph "Top
level Python Code" because you mention in the explanation "top level python
code" but it's not defined till the user read the following paragraph. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
