ashb commented on pull request #16960: URL: https://github.com/apache/airflow/pull/16960#issuecomment-879703912
Yeah, the code in https://github.com/apache/airflow/blob/ab5f770bfcd8c690cbe4d0825896325aca0beeca/airflow/models/taskinstance.py#L2063-L2073 is never run by python -- it's only picked up by code analysers. This was my bad -- I added the relationship in the first place, and I wasn't aware that the side where the relationship is defined matter. But yes, changing the relationship sounds like the better fix. @penggongkui Please also target all PRs directly to the `main` branch, and then once it's merged then we (committers/release managers) will cherry-pick it in to the release branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
