o-nikolas commented on pull request #17145: URL: https://github.com/apache/airflow/pull/17145#issuecomment-886868621
> I propose if we can rename parameter to `recursive` in place of (`include_subfolders` or `include_common_prefixes`) in `s3listoperator` to be in concordance with `aws s3 ls` command line tool options. Default recursive is true to retain the current behavior of operator. > thoughts @o-nikolas @jarfgit ? I think that's a perfectly fine name, but I don't like the reasoning of tying it to the `aws s3 ls` command. If anything I think we should be tying to choose naming that closely follows the boto api that this operator wraps (`list_objects_v2`) and that api uses the common S3 language of `prefixes`. But again, I think `recursive` is expressive enough and I'm happy to agree to that :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
