potiuk commented on a change in pull request #17273:
URL: https://github.com/apache/airflow/pull/17273#discussion_r678660274
##########
File path: airflow/providers/samba/hooks/samba.py
##########
@@ -16,67 +16,229 @@
# specific language governing permissions and limitations
# under the License.
-import os
+import posixpath
+from functools import wraps
+from shutil import copyfileobj
+from typing import Optional
-from smbclient import SambaClient
+import smbclient
from airflow.hooks.base import BaseHook
class SambaHook(BaseHook):
- """Allows for interaction with an samba server."""
+ """Allows for interaction with a Samba server.
+
+ :param samba_conn_id: The connection id reference.
+ :type samba_conn_id: str
+ :param share:
+ An optional share name. If this is unset then the "schema" field of
+ the connection is used in its place.
+ :type share: str
+ """
conn_name_attr = 'samba_conn_id'
default_conn_name = 'samba_default'
conn_type = 'samba'
hook_name = 'Samba'
- def __init__(self, samba_conn_id: str = default_conn_name) -> None:
+ def __init__(self, samba_conn_id: str = default_conn_name, share:
Optional[str] = None) -> None:
super().__init__()
- self.conn = self.get_connection(samba_conn_id)
+ conn = self.get_connection(samba_conn_id)
+
+ if not conn.login:
+ self.log.info("Login not provided")
+
+ if not conn.password:
+ self.log.info("Password not provided")
+
+ self._host = conn.host
+ self._share = share or conn.schema
+ self._connection_cache = connection_cache = {}
+ self._conn_kwargs = {
+ "username": conn.login,
+ "password": conn.password,
+ "port": conn.port or 445,
+ "connection_cache": connection_cache,
+ }
+
+ def __enter__(self):
+ # This immediately connects to the host (which can be
Review comment:
You could see some of those in other providers - for example look at the
Google provider:
https://github.com/apache/airflow/blob/main/airflow/providers/google/CHANGELOG.rst
- usually when there are braking changes that require more than one-line
mentioning.
Even in Samba, we've added a warning when we removed "apply_default" (this
was a global one and it actually did NOT really apply to samba but it went
there as it was "all operator" change.
https://github.com/apache/airflow/blob/main/airflow/providers/samba/CHANGELOG.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
