uranusjr commented on a change in pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#discussion_r679620955



##########
File path: airflow/timetables/base.py
##########
@@ -79,6 +74,18 @@ def interval(cls, start: DateTime, end: DateTime) -> 
"DagRunInfo":
         """
         return cls(run_after=end, data_interval=DataInterval(start, end))
 
+    @property
+    def schedule_date(self) -> DateTime:

Review comment:
       No, this is the “logical” date of the DagRun, not the earliest time to 
schedule it.
   
   The equivalence of `run_date` in the proposal is `run_after` in the 
implementation (because I simply forgot `run_date` was in the proposal…); we 
can change that if needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to