bradarndt opened a new pull request #17477:
URL: https://github.com/apache/airflow/pull/17477


   This PR changes the existing behavior ["extra links" added to 
operators](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/define_extra_link.rst)
 such that any _relative_ links open in place rather than in a new window/tab.  
This is consistent with the way other links/buttons in Airflow work today.  Any 
absolute links will continue to open in a new window/tab as they do today.
   
   For the purposes of this change, a "relative" link is defined as any link 
url that does not satisfy the following regular expression: `^(?:[a-z]+:)?//`.  
See [this stack overflow post](https://stackoverflow.com/a/19709846) for more 
in depth discussion.
   
   
   _Note: As a first time contributor, I've followed the contributing 
documentation as much as possible.  I could not find any existing tests to 
update for the www js code, so given the simplicity of this change, I did not 
add any tests, however, I did run all WWW tests as well as static analysis.  
Please let me know if i missed something or this is otherwise unacceptable.  
Looking forward to feedback!_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to