[GitHub] [airflow] Sonins edited a comment on pull request #17428: Fix elasticsearch-secret template port default function

[GitBox]

Sonins edited a comment on pull request #17428:
URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972


   I wrote new test coverage. Here's my local test result.
   
   with original template
   
   ```
   root@cbffb11c21aa:/opt/airflow# pytest 
chart/tests/test_elasticsearch_secret.py
   ```
   
![image](https://user-images.githubusercontent.com/26663842/128650816-9961c357-c5f6-465a-b2a5-3a50bfea2fcf.png)
   
   with fixed template
   
   ```
   root@cbffb11c21aa:/opt/airflow# pytest 
chart/tests/test_elasticsearch_secret.py 
   ```
   
   
![image](https://user-images.githubusercontent.com/26663842/128650828-fa649c79-9c91-4121-86ce-712c5ab6f109.png)
   
   And also, Should the default port be 80? As I know, elasticsearch uses port 
9200 as default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org