LionelZhao28 edited a comment on pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#issuecomment-895670688


   > I think local_run_id might be misleading - if people will see different 
value in the UI and in the DB that might be quite confusing. Plus it adds 
unnecesary field in the DB. The run_id is used throughout the whole UI and It 
would be quite a change to use 'local' version all over the UI. And it will be 
even harder to test. I agree with @uranusjr that using local timezone settings 
always is a good idea, but it has to be thoroughly unit-tested.
   
   Agree.
   I've set this PR to WIP.
   I will add the unit test about it.
   Because we don't use the `daylight saving time` in China,  I will be very 
glad if you can help me to do this if possible. Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to