potiuk commented on pull request #17545: URL: https://github.com/apache/airflow/pull/17545#issuecomment-897142870
> And what do you call your branching operator ... "check-if-saturday-task123". It doesn't seem particularly elegant to me. I agree with @kaxil that this case is not best (and it will be much better handled by AIP-39: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-39+Richer+scheduler_interval) - on the whole DAG level. But I see the need of being able to programmatically skip or fail a task on a condition (not necessarily scheduled one, but if it happens to be based on day of week, that's also fine). I think, to be honest it's a bad idea to skip certain tasks immediately at scheduling time. While it might sound tempting and a nice "shortcut" I think this is also dangerous as it might heavily impact scheduler processing time. It's crucial that scheduler runs as fast as it can just doing scheduling, and adding a "dynamic" logic per task which is executed - necessarily 0 in a tight scheduling loop for each of the tasks it attempts to schedule is likely a bad idea from scalability point of view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
