subkanthi commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r689213294
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec,
'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec,
'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec,
'volumes')
Review comment:
The concern is more on line 291 where merged_spec is passed to the
function and the return value is assigned back to merged_spec, someone making
change in the future might not notice it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
