ashb opened a new pull request #5162: [AIRFLOW-4358] Speed up test_jobs by not 
running tasks
URL: https://github.com/apache/airflow/pull/5162
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-4358
   
   ### Description
   
   - [ ] We don't care about the behaviour of the tasks (we test those 
elsewhere) - we just care that the task is "run" and yeilds a state, which we 
can all do more directly.
   
     On my laptop this takes the time for SchedulerJobTest from 133s to 35s, 
and reduces the BackfillJobTests from >5mins to mere seconds!
   
     I think this approach still tests the behaviour well enough
   
   ### Tests
   
   - [x] Changed tests to check events that are run via executor, but it won't 
run it
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to