milton0825 commented on a change in pull request #5094: [AIRFLOW-4306] Global
operator extra links
URL: https://github.com/apache/airflow/pull/5094#discussion_r277920575
##########
File path: airflow/models/baseoperator.py
##########
@@ -973,6 +986,25 @@ class BaseOperatorLink:
__metaclass__ = ABCMeta
+ @property
+ @abstractmethod
+ def name(self):
+ # type: () -> str
+ """
+ Name of the link. This will be the button name on the task UI.
+
+ :return: link name
+ """
+ pass
+
@abstractmethod
def get_link(self, operator, dttm):
+ # type: (BaseOperator, datetime) -> str
+ """
+ Link to external system.
+
+ :param operator: airflow operator
Review comment:
I have a type hint in:
https://github.com/apache/airflow/pull/5094/files/8be65327e8cd1f4cf7dedcb90b8eacc4fa5f635d#diff-b5ec97b8301ab688b7e045426f24d485R1002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
