uranusjr commented on a change in pull request #17797:
URL: https://github.com/apache/airflow/pull/17797#discussion_r694509540



##########
File path: tests/task/task_runner/test_standard_task_runner.py
##########
@@ -62,15 +62,12 @@ def logging_and_db(self):
         (as the test environment does not have enough context for the normal
         way to run) and ensures they reset back to normal on the way out.
         """
+        clear_db_runs()
         dictConfig(LOGGING_CONFIG)
         yield
         airflow_logger = logging.getLogger('airflow')
         airflow_logger.handlers = []
-        try:
-            clear_db_runs()
-        except Exception:
-            # It might happen that we lost connection to the server here so we 
need to ignore any errors here
-            pass
+        clear_db_runs()

Review comment:
       Is this related? I’m suspecting the try-except is there for a reason… 
but we can always add it back anyway.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to