ashb commented on a change in pull request #17100:
URL: https://github.com/apache/airflow/pull/17100#discussion_r701000150
##########
File path: airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py
##########
@@ -100,15 +99,16 @@ def __init__(
self.facebook_conn_id = facebook_conn_id
self.api_version = api_version
self.fields = fields
- self.params = params
self.gzip = gzip
self.impersonation_chain = impersonation_chain
def execute(self, context: dict):
service = FacebookAdsReportingHook(
facebook_conn_id=self.facebook_conn_id,
api_version=self.api_version
)
- rows = service.bulk_facebook_report(params=self.params,
fields=self.fields)
+ rows = service.bulk_facebook_report(
+ params={k: v.resolve() for k, v in self.params.items()},
fields=self.fields
+ )
Review comment:
Yeah, so _this_ `params` is a name clash, and shouldn't be using the
_same_ params.
This needs to not be the same as `dag.params`/typed/ etc.
I.e. this change needs to be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
