andrewgodwin commented on a change in pull request #18112:
URL: https://github.com/apache/airflow/pull/18112#discussion_r705604901
##########
File path: airflow/exceptions.py
##########
@@ -256,12 +278,21 @@ def __init__(
self.method_name = method_name
self.kwargs = kwargs
self.timeout = timeout
+
# Check timeout type at runtime
if self.timeout is not None and not hasattr(self.timeout,
"total_seconds"):
raise ValueError("Timeout value must be a timedelta")
+ # Check keyword arguments
+ if kwargs:
+ if method_name is None:
+ raise ValueError("Keyword arguments not allowed when method is
not specified")
Review comment:
> don't know about or want to know about deferred tasks
Wait, so you're injecting deferral into operators via the pre_execute hook
that otherwise may not expect it? I would be wary of doing that, there might be
side-effects from operators that do too much in their own init or pre-execute
code...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
