[
https://issues.apache.org/jira/browse/AIRFLOW-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827422#comment-16827422
]
ASF GitHub Bot commented on AIRFLOW-4419:
-----------------------------------------
KevinYang21 commented on pull request #5194: [WIP][AIRFLOW-4419] Refine
concurrency check in scheduler
URL: https://github.com/apache/airflow/pull/5194
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-4419) issues and references
them in the PR title.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Optimized the pool, dag and task concurrency calculation logic to make it
faster. Also fix a bug where current task concurrency should not increase if
the executor already has the task.
Added helper method in pool.py to access default pool size and optimized
open slot querying method fo r performance.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Concurrency calculation in scheduler is slow and has a bug
> ----------------------------------------------------------
>
> Key: AIRFLOW-4419
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4419
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Kevin Yang
> Assignee: Kevin Yang
> Priority: Minor
>
> The pool, dag and task concurrency calculation logic is slow and can be
> optimized. Also current task concurrency should not increase if the executor
> already has the task.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
