jaketf opened a new pull request #18222: URL: https://github.com/apache/airflow/pull/18222
<!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> make current_user_has_permissions backwards compatible --- **^ Add meaningful description above** IMHO Subclasses that already override `get_current_user_permissions` should not also have to override the newly added method `current_user_has_permissions` and this PR would fix that. Currently `AiflowSecurityManager.current_user_has_permissions` sort of duplicates logic of `AiflowSecurityManager.get_current_user_permissions` but bakes in the assumption that all permissions come from roles. As of https://github.com/apache/airflow/pull/17838 the new method is used when deciding to route a user to the no permissions or role page. This causes a regression for existing subclasses of `AirflowSecurityManager` that override `get_current_user_permissions` directly and those permissions do not come from a role. Such subclasses should still allow users with permissions to the airflow UI. I'm not sure how best to add test coverage for something like this. cc @jedcunningham @andrewgodwin Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
