ignaski commented on a change in pull request #18042:
URL: https://github.com/apache/airflow/pull/18042#discussion_r710775770



##########
File path: airflow/config_templates/config.yml
##########
@@ -1351,6 +1351,20 @@
       example: "/path/to/my_html_content_template_file"
       default: ~
       see_also: ":doc:`Email Configuration </howto/email-config>`"
+    - name: email_from_email
+      description: |
+        Email address that will be used as sender address.
+      version_added: 2.2.0
+      type: string
+      example: "airf...@example.com"
+      default: ~
+    - name: email_from_name

Review comment:
       > Also, as I mentioned in the other PR, `from_name` is not needed at all 
since `from_email` can just be set to `Display Name <m...@example.com>`.
   
   It would have to be split for Sendgrid implementation because it expects two 
separate values. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to