SamWheating commented on a change in pull request #18197:
URL: https://github.com/apache/airflow/pull/18197#discussion_r711838902
##########
File path: tests/providers/google/cloud/operators/test_dataproc_system.py
##########
@@ -54,12 +75,14 @@ def setUp(self):
self.create_gcs_bucket(BUCKET)
self.upload_content_to_gcs(lines=pyspark_file, bucket=GCS_URI,
filename=PYSPARK_MAIN)
self.upload_content_to_gcs(lines=sparkr_file, bucket=GCS_URI,
filename=SPARKR_MAIN)
+ self.upload_content_to_gcs(lines=yml_config_file, bucket=GCS_URI,
filename=YML_CONFIG_FILE)
Review comment:
Using both `yml_config_file` and `YML_CONFIG_FILE` is bad for
readability in my opinion, maybe one should be renamed to reduce any confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
