jedcunningham commented on a change in pull request #18249:
URL: https://github.com/apache/airflow/pull/18249#discussion_r717791801
##########
File path: chart/files/pod-template-file.kubernetes-helm-yaml
##########
@@ -56,6 +56,7 @@ spec:
image: {{ template "pod_template_image" . }}
imagePullPolicy: {{ .Values.images.airflow.pullPolicy }}
name: base
+ securityContext: {{-
.Values.podTemplateSecurity.containerSecurityContext | default
(.Values.podSecurity.containerSecurityContext) | toYaml | nindent 4 }}
Review comment:
This should use `workers.containerSecurityContext` instead of having a
separate param.
##########
File path: chart/values.yaml
##########
@@ -383,6 +393,19 @@ workers:
maxSurge: "100%"
maxUnavailable: "50%"
+ # When not set, the values defined on podSecurity.securityContext will be
used
+ securityContext:
+ runAsUser: 50000
+ fsGroup: 0
Review comment:
```suggestion
securityContext: {}
# runAsUser: 50000
# fsGroup: 0
```
We shouldn't set these for all of the components, otherwise
`podSecurity.securityContext` will never actually be used and isn't an easy way
to set it across the board.
##########
File path: chart/files/pod-template-file.kubernetes-helm-yaml
##########
@@ -87,9 +88,7 @@ spec:
- name: {{ template "registry_secret" . }}
{{- end }}
restartPolicy: Never
- securityContext:
- runAsUser: {{ .Values.uid }}
- fsGroup: {{ .Values.gid }}
+ securityContext: {{- .Values.podTemplateSecurity.securityContext | default
(.Values.podSecurity.securityContext) | toYaml | nindent 4 }}
Review comment:
Same here, should use `workers.securityContext`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
