dstandish commented on a change in pull request #18447: URL: https://github.com/apache/airflow/pull/18447#discussion_r718025826
########## File path: airflow/providers/amazon/aws/hooks/redshift_statement.py ########## @@ -0,0 +1,144 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Interact with AWS Redshift, using the boto3 library.""" + +from typing import Callable, Dict, Optional, Tuple, Union + +import redshift_connector +from redshift_connector import Connection as RedshiftConnection + +from airflow.hooks.dbapi import DbApiHook + + +class RedshiftStatementHook(DbApiHook): Review comment: @mik-laj agreed with @josh-fell on this one, and i think i now agree with this too. namely we should do the following: * add RedshiftSqlHook to the existing `redshift` module (i.e. in the same module as the existing RedshiftHook) * deprecate RedshiftHook (renaming it to RedshiftClusterHook) -- this doesn't necessarily need to happen in this PR And those names we intend to stick with (i.e. ultimately we keep two hooks `RedshiftSqlHook` and `RedshiftClusterHook`) In the next major release _for this provider_ (which now that i think of it does not have to be in airflow 3.0, since providers have separate release schedule), we remove `RedshiftHook` and we are left with `RedshiftSqlHook` and `RedshiftClusterHook` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
