ashb commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723129199
########## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ########## @@ -27,7 +27,7 @@ Here is a sample configuration: [secrets] backend = airflow.providers.amazon.aws.secrets.secrets_manager.SecretsManagerBackend - backend_kwargs = {"connections_prefix": "airflow/connections", "variables_prefix": "airflow/variables", "profile_name": "default", "full_url_mode": False} + backend_kwargs = {"connections_prefix": "airflow/connections", "variables_prefix": "airflow/variables", "profile_name": "default", "full_url_mode": "False"} Review comment: Isn't backend kwargs parsed as json? So the correct fix for this would be ```suggestion backend_kwargs = {"connections_prefix": "airflow/connections", "variables_prefix": "airflow/variables", "profile_name": "default", "full_url_mode": false} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org