[ 
https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830619#comment-16830619
 ] 

ASF subversion and git services commented on AIRFLOW-4269:
----------------------------------------------------------

Commit 2b488bffc60a97cd01a5b032d9d5435b4737d2b7 in airflow's branch 
refs/heads/v1-10-test from Xiaodong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2b488bf ]

[AIRFLOW-4269] Minor acceleration of jobs._process_task_instances() (#5076)

* [AIRFLOW-4269] Minor acceleration of jobs._process_task_instances()

by breaking from unnecessary steps of a for-loop

* [AIRFLOW-4269] Improve log.info a bit

(cherry picked from commit aeef5dfe2794c9e2b742625f4adf9b0ee4124fed)


> For-lop in jobs._process_task_instances can be faster by breaking from 
> unnecessary steps
> ----------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4269
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4269
>             Project: Apache Airflow
>          Issue Type: Improvement
>    Affects Versions: 1.10.2
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923]
>  is a "continue" while it should be a break.
> When *len(active_dag_runs) >= dag.max_active_runs* , the following part of 
> the for-loop will give the same result and result in a "continue" again and 
> again, doing nothing. 
> We should use a "break" here.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to