uranusjr commented on a change in pull request #17651:
URL: https://github.com/apache/airflow/pull/17651#discussion_r723788007
##########
File path: tests/test_utils/logging_command_executor.py
##########
@@ -62,5 +62,39 @@ def check_output(self, cmd):
return output
+class CMDExecutor(LoggingCommandExecutor):
Review comment:
I think we should spell out *Command* instead; there's no advantage to
save the four characters. Same goes for other additions.
##########
File path: airflow/exceptions.py
##########
@@ -261,3 +261,7 @@ def __repr__(self) -> str:
class TaskDeferralError(AirflowException):
"""Raised when a task failed during deferral for some reason."""
+
+
+class CMDExecutionError(AirflowException):
+ """Raise in case of error during cmd execution"""
Review comment:
Since this exception is only ever raised in tests, it should not live in
the main Airflow code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
