anaynayak commented on issue #18549:
URL: https://github.com/apache/airflow/issues/18549#issuecomment-937851583


   @potiuk  I think I can try this one. 
   
   My current understanding of the code + changes required:
   1. `CloudwatchTaskHandler` delegates to `watchtower.CloudWatchLogHandler` 
which provides the option to create a log group if it doesn't exist (true by 
default) 
https://github.com/kislyuk/watchtower/blob/develop/watchtower/__init__.py#L84
   2. Do we intend to continue with the existing behavior but allow users to 
override based on config values defined ? e.g.  `conf.get('logging', 
'CLOUDWATCH_CREATE_LOG_GROUP', fallback=True)` similar to 
https://github.com/apache/airflow/blob/main/airflow/config_templates/airflow_local_settings.py#L209
 ?
   
   Let me know if thats the approach. Can do the changes accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to