[ 
https://issues.apache.org/jira/browse/AIRFLOW-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831228#comment-16831228
 ] 

ASF GitHub Bot commented on AIRFLOW-4417:
-----------------------------------------

andrewhharmon commented on pull request #5223: [AIRFLOW-4417] Add AWS IAM 
authenication for PostgresHook
URL: https://github.com/apache/airflow/pull/5223
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-4417
   
   ### Description
   
   - [x] Enhance the existing PostgresHook to allow for IAM authentication for 
RDS Postgres and Redshift.
   
   ### Tests
   
   - [x] My PR adds the following unit tests
     - test_get_conn()
     - test_get_conn_rds_iam_postgres()
     - test_get_conn_rds_iam_redshift
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enhance Postgres hook to allow for IAM authentication
> -----------------------------------------------------
>
>                 Key: AIRFLOW-4417
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4417
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Andrew Harmon
>            Assignee: Andrew Harmon
>            Priority: Minor
>              Labels: features
>
> Enhance to current PostgresHook to allow for connecting to AWS RDS and 
> Redshift with AWS IAM authentication. 
> The hook will use an AWSHook to generate a temporary token via boto3. This 
> token will be passed in as the password.
> To specify IAM authentication, the following extras can be added to the 
> Postgres connection
> {
>   "iam":true,
>   "region":"us-west-1",
>   "redshift": false
> }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to