asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r731265880
##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: bool) -> Optio
if self.retrieve_output:
ret = return_value
elif self.do_xcom_push:
- ret = self._get_return_value_from_logs(res_lines, line)
+ ret = self._get_return_value_from_logs(lines, lines[-1])
return ret
Review comment:
I guess this small test help understand what I meant
```python
#!/usr/bin/python3
str = r"""this is
an 'herestring'
with some lines,
but now\n there's even more \n lines, but are they real?\n
string example....\nwow!!!"""
print (str.splitlines())
```
In this case, the difference between an expected results and an unexpected
results lays in the `r`,
without the r""", splitlines would also process the "inline `\n`'s"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
