dstandish commented on a change in pull request #19267:
URL: https://github.com/apache/airflow/pull/19267#discussion_r738962350
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -417,7 +417,10 @@ def _serialize_param(cls, param: Param):
@classmethod
def _deserialize_param(cls, param_dict: Dict):
param_class = import_string(param_dict.pop(Param.CLASS_IDENTIFIER))
- param_kwargs = cls._deserialize(param_dict)
+ try:
+ param_kwargs = cls._deserialize(param_dict)
+ except KeyError:
+ param_kwargs = param_dict
Review comment:
that's not what's going on here
the KeyError is essentially 2.2.0 serialiazation approach, which for params,
doesn't run their attrs through our serialization logic, but assumes they are
json serializable (which is the problem, because in the case of sets they are
not)
but so when you try to _deserialize something that was not _serialize(d),
you get a KeyError and in this case we can just take the args as they are --
they weren't "serialized" anyway, so we don't need to "deserialize" them
_however_, i am working on a better approach, cleaner, and i'll push it
tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
