john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-967559744
> > this is already implemented in the gcp secret_manager -> > > https://github.com/apache/airflow/blob/4f1e66d0227fba7a1378e895b9186711c03ead61/airflow/providers/google/cloud/_internal_client/secret_manager_client.py#L92 > > > > It make sence to have the same in thie aws secret_manager > > One difference is, there it does not catch _all_ exceptions but only certain ones. The intent was to future-proof the code, as regardless of the reason for the exception it should fall back. If required the last catch-all can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
