kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r750906779
##########
File path: tests/kubernetes/test_pod_generator.py
##########
@@ -658,11 +658,12 @@ def test_deserialize_model_file(self):
def test_pod_name_confirm_to_max_length(self, _, pod_id):
name = PodGenerator.make_unique_pod_id(pod_id)
assert len(name) <= 253
- parts = name.split(".")
- if len(pod_id) <= 63:
+ parts = name.split("-")
+ if len(pod_id) <= 63 - 33:
Review comment:
I added a few notes explaining where these numbers came from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
