jedcunningham commented on a change in pull request #19686:
URL: https://github.com/apache/airflow/pull/19686#discussion_r752620097
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -91,6 +91,14 @@ Example pod templates
With these requirements in mind, here are some examples of basic
``pod_template_file`` YAML files.
+.. note::
+
Review comment:
Maybe we should use a different word than "configuration". I didn't mean
specifically "Airflow configuration", I meant in general. Another example would
be `imagePullSecrets` - if you need it for the scheduler etc, you'll need it
here too.
I'm _more_ in favor of stating these are for inspiration instead of implying
they work if you use the "defaults".
Maybe something along these lines:
The following `pod_template_file` examples are for inspiration. This
template will be used to create your workers, so take care to ensure all of
your Airflow configuration and Kubernetes secrets/mounts/etc are added so the
worker pod can function properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
