malthe commented on a change in pull request #19806:
URL: https://github.com/apache/airflow/pull/19806#discussion_r757108644
##########
File path: airflow/providers/microsoft/psrp/hooks/psrp.py
##########
@@ -31,13 +33,19 @@ class PSRPHook(BaseHook):
Hook for PowerShell Remoting Protocol execution.
The hook must be used as a context manager.
+
+ :param psrp_conn_id: Required. The name of the PSRP connection.
+ :type psrp_conn_id: str
+ :param logging: If true (default), log command output and streams during
execution.
+ :type logging: bool
Review comment:
@uranusjr I looked into this in more detail now and the way it works is
that there is an _operational timeout_ after which polling must return with an
updated status (or a failure) – but it can return earlier.
I did a test where I issued the PowerShell cmdlet `Start-Sleep -s 3;
Write-Host "Hello"` (sleep for three seconds) in a loop. Even though the
default operational timeout is 20 seconds, each polling action returned with a
new status after 3 seconds.
I have updated the code to reflect this new understanding and instead of a
polling interval there is now an overrideable operational timeout. For example,
setting it to 1 in the above example would mean that every second we get a
status update, but only every 3 seconds do we get a "Hello" information stream
record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
