fredthomsen commented on a change in pull request #18542:
URL: https://github.com/apache/airflow/pull/18542#discussion_r757229481



##########
File path: chart/templates/webserver/webserver-ingress.yaml
##########
@@ -39,12 +39,27 @@ metadata:
     {{- toYaml . | nindent 4 }}
   {{- end }}
 spec:
-  {{- if .Values.ingress.web.tls.enabled }}
+  {{- if and .Values.ingress.web.hosts (.Values.ingress.web.hosts | first | 
kindIs "string" | not) }}
+  {{- $anyTlsHosts := false -}}
+  {{- range .Values.ingress.web.hosts }}
+  {{- if .tls.enabled }}

Review comment:
       This update is very easy to make, so I just went ahead and did it.  On 
that note the lack of short circuit boolean evaluation in go templates is 
aggravating.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to