potiuk opened a new issue #19891:
URL: https://github.com/apache/airflow/issues/19891


   ### Body
   
   For a few weeks MyPy checks have been disabled after the switch to Python 
3.7 (per #19317).
   
   We should, however, re-enable it back as it is very useful in catching a 
number of mistakes. 
   
   I am re-adding the mypy pre-commit now - with mypy bumped to 0.910. This 
version detects far more number of errors and we should fix them all before we 
switch the CI check back.
   
   The way I brought it back https://github.com/apache/airflow/pull/19890
   
   * mypy will be running for incremental changes in pre-commit, same as 
before. This will enable incremental fixes of the code changed by committers 
who use pre-commits locally
   * mypy on CI runs in non-failing mode. When main pre-commit check is run, 
mypy is disabled, but then it is run as separate step (which does not fail but 
will show the result of running mypy on all our code). This will enable us to 
track the progress of fixes
   
   We should make a concerted effort now and incrementally fix all the mypy 
incompatibilities - ideally package/by/package to avoid huge code reviews.
   
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow 
project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to