ashb commented on a change in pull request #19965:
URL: https://github.com/apache/airflow/pull/19965#discussion_r771488538



##########
File path: airflow/models/baseoperator.py
##########
@@ -196,16 +216,37 @@ def apply_defaults(self, *args: Any, **kwargs: Any) -> 
Any:
             self._BaseOperator__instantiated = True
             return result
 
+        apply_defaults.__non_optional_args = non_optional_args  # type: ignore
+        apply_defaults.__param_names = set(non_varaidc_params.keys())  # type: 
ignore
+
         return cast(T, apply_defaults)
 
     def __new__(cls, name, bases, namespace, **kwargs):
         new_cls = super().__new__(cls, name, bases, namespace, **kwargs)
+        try:
+            # Update the partial descriptor with the class method so it call 
call the actual function (but let
+            # subclasses override it if they need to)
+            partial_desc = vars(new_cls)['partial']

Review comment:
       ```
   airflow/models/baseoperator.py:229: in __new__
       partial_desc = new_cls.partial
   airflow/models/baseoperator.py:107: in __get__
       return self.class_method.__get__(cls, cls)
   E   AttributeError: 'NoneType' object has no attribute '__get__'
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to