potiuk commented on a change in pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#discussion_r775865797
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -95,13 +96,46 @@ def shell(verbose: bool):
@option_verbose
-@main.command()
-def build_ci_image(verbose: bool):
- """Builds breeze.ci image for breeze.py."""
+@main.command(name='build-ci-image')
+@click.option(
+ '--additional-extras',
+ help='This installs additional extra package while installing airflow in
the image.',
+)
+@click.option('-p', '--python', help='Choose your python version')
+@click.option(
+ '--additional-dev-apt-deps', help='Additional apt dev dependencies to use
when building the images.'
+)
+@click.option(
+ '--additional-runtime-apt-deps',
+ help='Additional apt runtime dependencies to use when building the
images.',
+)
+@click.option(
+ '--additional-python-deps', help='Additional python dependencies to use
when building the images.'
+)
+@click.option('--github-repository', help='Choose repository to push/pull
image.')
+def build_ci_image(
+ verbose: bool,
+ additional_extras: str,
Review comment:
I think we should use Optional[str] here more often and set defaults to
`None` for all parameters that were "empty" by defaiult in Bash. The reason
they were '" was because it is easier in Bash (MacOS) to deal with empty than
undefined values, but we have much more freedom now in Python and `None = "not
set"` is better approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
