potiuk commented on issue #20500:
URL: https://github.com/apache/airflow/issues/20500#issuecomment-1002192831


   > Please be noted that the stripping is in the current airflow code; I 
copied the behavior to keep things the same when nothing bad happens (and if we 
don't strip, we get extra blank lines in the log). And since Python uses 
references, I don't see any "extra" buffering here. The only changed part is 
when the buffer (that StreamLogWriter keeps log messages) is cleared, before or 
after the recursion.
   
   Then I simply did not understand what you proposed. Maybe open a PR and we 
can discuss it with others and see if it makes sense?  It's always best to 
discuss stuff when there is a draft PR showing the change and explaining the 
reasoning.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to