kaxil commented on a change in pull request #20795:
URL: https://github.com/apache/airflow/pull/20795#discussion_r781609000
##########
File path: airflow/models/taskinstance.py
##########
@@ -1286,7 +1287,7 @@ def check_and_change_state_before_execution(
return True
def _date_or_empty(self, attr: str):
- result = getattr(self, attr, None) # type: datetime
+ result = getattr(self, attr, None) # type: Optional[datetime]
Review comment:
```suggestion
result: Optional[datetime] = getattr(self, attr, None)
```
nit: Feels more cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
