SamWheating commented on a change in pull request #20733:
URL: https://github.com/apache/airflow/pull/20733#discussion_r781654455
##########
File path: airflow/www/views.py
##########
@@ -3127,6 +3127,44 @@ def robots(self):
"""
return send_from_directory(current_app.static_folder, 'robots.txt')
+ @expose('/audit_log')
+ @auth.has_access(
+ [
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG),
Review comment:
```suggestion
(permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG),
(permissions.ACTION_CAN_READ, permissions.RESOURCE_AUDIT_LOG),
```
Even though a lot of historical information is also present in the DAG view,
I think we should prevent users from viewing this page unless they have full
audit log access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
