SamWheating commented on a change in pull request #20733:
URL: https://github.com/apache/airflow/pull/20733#discussion_r783322325
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -658,6 +658,18 @@ auto_refresh_interval = 3
# Boolean for displaying warning for publicly viewable deployment
warn_deployment_exposure = True
+# Number of dags to look back for dag audit log view
+audit_trail_query_days = 31
Review comment:
Agreed - if people have large volumes of logs then they may introduce
their own log rotation / table cleanup to deal with this, but I don't think
that this needs to be handled here.
It also introduces an artificial limitation on the audit view, as users will
be unable to view old events even if they still existent in the database. If
you're really worried about performance or table size here maybe we could
implement query-level pagination?
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -658,6 +658,18 @@ auto_refresh_interval = 3
# Boolean for displaying warning for publicly viewable deployment
warn_deployment_exposure = True
+# Number of dags to look back for dag audit log view
+audit_trail_query_days = 31
Review comment:
Agreed - if people have large volumes of logs then they may introduce
their own log rotation / table cleanup to deal with this, but I don't think
that this needs to be handled here.
It also introduces an artificial limitation on the audit view, as users will
be unable to view old events even if they still existent in the database.
If we're really worried about performance or table size here maybe we could
implement query-level pagination?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
