potiuk commented on pull request #21032: URL: https://github.com/apache/airflow/pull/21032#issuecomment-1021602404
@jedcunningham - `v2-2-test` is all yours. Just for the record of the summary of "Maybe" changes that I've found during complete review: IMHO: Those are the changes you should look at: * airflow/jobs/scheduler_job.py airflow/sensors/base.py -> https://github.com/apache/airflow/pull/20151/ - Deprecate smart sensors. This is harmless and I think the sooner users gets the deprecation notice the better (this is classified as "doc-only" but you might want to remove it or maybe re-classify it to "misc" or something) * Also (that's part of the 32 "changelog" changes to review - the only "suspicious" setup. change is removing vendoring-in connexion. But this is very safe IMHO (but you might want to revert it if you do not want to include it). https://github.com/apache/airflow/pull/20910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
