norm commented on a change in pull request #21472:
URL: https://github.com/apache/airflow/pull/21472#discussion_r804768240



##########
File path: airflow/api/client/__init__.py
##########
@@ -27,14 +27,14 @@
 def get_current_api_client() -> Client:
     """Return current API Client based on current Airflow configuration"""
     api_module = import_module(conf.get('cli', 'api_client'))  # type: Any
-    auth_backend = api.load_auth()
+    auth_backends = api.load_auth()
     session = None
-    session_factory = getattr(auth_backend, 'create_client_session', None)
+    session_factory = getattr(auth_backends, 'create_client_session', None)

Review comment:
       Indeed, I pushed the branch after a search/replace but not necessarily 
in a shippable state. :)
   
   I've fixed this somewhat in 3f3126f, and whilst it now satisfies the tests 
it is not doing the right thing. There's an assumption of *one* auth in the 
returned `api_client` which means more work than merely making the tests pass 
by returning the *first* backend.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to