ephraimbuddy commented on a change in pull request #21578:
URL: https://github.com/apache/airflow/pull/21578#discussion_r806628667
##########
File path: tests/operators/test_python.py
##########
@@ -999,6 +999,21 @@ def test_lambda(self):
with pytest.raises(AirflowException):
PythonVirtualenvOperator(python_callable=lambda x: 4,
task_id='task', dag=self.dag)
+ def test_system_site_packages_with_wildcard_callable(self):
+ def mycallable(**kwargs):
Review comment:
Spent time on it trying to figure out why but it seems that with site
packages, the many airflow pickleable objects are no longer pickleable. If you
remove everything from
https://github.com/apache/airflow/blob/2d6282d6b7d8c7603e96f0f28ebe0180855687f3/airflow/operators/python.py#L358
except config and params, it works with site packages
##########
File path: tests/operators/test_python.py
##########
@@ -1053,7 +1068,7 @@ def f(
):
pass
- self._run_as_operator(f, use_dill=True, system_site_packages=True,
requirements=None)
+ self._run_as_operator(f, use_dill=True, system_site_packages=False,
requirements=None)
Review comment:
I'm surprised that this test passes before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
