jedcunningham commented on a change in pull request #21538:
URL: https://github.com/apache/airflow/pull/21538#discussion_r807057403



##########
File path: UPDATING.md
##########
@@ -80,6 +80,13 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### You can't name zip files as ending with .py for DAGs
+
+It was previously possible to load any files as zip files in the DAGs folder 
via `zipfile.is_zipfile`.
+
+Now .py (extension) files are going to be loaded as modules without checking 
whether it is zipfile. (Less IO)
+If .py file in the DAGs folder were a zip compressed file, processing it would 
be failed with exception.

Review comment:
       ```suggestion
   ### Zip files in the DAGs folder can no longer have a `.py` extension 
   
   It was previously possible to have any extension for zip files in the DAGs 
folder. Now `.py` files are going to be loaded as modules without checking 
whether it is a zip file, as it leads to less IO. If a `.py` file in the DAGs 
folder is a zip compressed file, parsing it will fail with an exception.
   ```
   
   Just some minor tweaks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to