Bowrna commented on a change in pull request #21145:
URL: https://github.com/apache/airflow/pull/21145#discussion_r812673596



##########
File path: dev/breeze/tests/test_cache.py
##########
@@ -62,6 +67,17 @@ def test_read_from_cache_file(param):
     if param_value is None:
         assert None is param_value
     else:
-        allowed, param_list = check_if_values_allowed(param + 's', param_value)
+        allowed, param_list = check_if_values_allowed(param, param_value)
         if allowed:
             assert param_value in param_list
+
+

Review comment:
       @potiuk Could you share your views on this test that I tried? 
   
   In the below code, If i tried `mock_path.assert_called_with(AIRFLOW_SOURCES 
/ ".build"/ param)` it didn't work. Can you explain why it doesn't work? I 
tried to find myself. But that part is not very clear to me




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to